Walkthrough

The PeerNetworkManager struct's DNS peer discovery mechanism was refactored to replace time-tracked, on-demand searches with a periodic timer-driven approach. A peer_search_started field was removed, and DNS discovery now runs at regular intervals via a dns_interval timer within the maintenance loop.

Changes

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰✨ The DNS search hops along with grace,
No need to track each starting place!
A timer ticks at intervals so true,
Discovery periodic—fresh and new!
One field removed, the maintenance glows bright,
Peer connections dancing through the night! 🌙

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

• 📝 Generate docstrings

dash-spv/src/network/manager.rs (1)

763-764: Use interval_at to defer the first DNS discovery probe by one interval period.

time::interval(DNS_DISCOVERY_DELAY) completes its first .tick() immediately, which would trigger DNS discovery on the very first maintenance loop iteration—potentially redundant with the immediate DNS discovery already performed in start() (lines 173–196). Defer the first tick by one period using interval_at:

Suggested change

-            let mut dns_interval = time::interval(DNS_DISCOVERY_DELAY);
+            let mut dns_interval =
+                time::interval_at(time::Instant::now() + DNS_DISCOVERY_DELAY, DNS_DISCOVERY_DELAY);

The is_connecting guard prevents duplicate connection attempts, so this is an efficiency improvement rather than a correctness issue.

• X
• Mastodon
• Reddit
• LinkedIn